Merge pull request 'align runner label to server config' (#12) from align-runner-label into master

Reviewed-on: http://192.168.1.74:30008/WesternTechnologies/goon_plugin/pulls/12

.github/workflows/ci.yml

@@ -8,7 +8,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/release.yml

@@ -0,0 +1,81 @@
+name: Release
+
+on:
+  push:
+    tags:
+      - 'v*'
+
+jobs:
+  release:
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Build
+        run: npm run build
+
+      - name: Package dist.zip
+        shell: bash
+        run: |
+          cd dist
+          zip -r "../vidplex-${{ github.ref_name }}.zip" .
+
+      - name: Create Gitea release
+        shell: bash
+        env:
+          GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
+          GITEA_API: ${{ secrets.GITEA_API || 'http://192.168.1.74:30008/api/v1' }}
+          REPO: ${{ github.repository }}
+          TAG: ${{ github.ref_name }}
+        run: |
+          if [ -z "$GITEA_TOKEN" ]; then
+            echo "::warning::GITEA_TOKEN secret is not set; skipping release creation. Add it in Gitea repo Settings > Secrets (repo scope)."
+            exit 0
+          fi
+
+          json_id() { node -e 'let d="";process.stdin.on("data",c=>d+=c).on("end",()=>{const j=JSON.parse(d||"{}");if(j.id==null){console.error("no release id:",JSON.stringify(j));process.exit(1)}console.log(j.id)})'; }
+
+          release_id=$(
+            curl -s -o /tmp/rel.json -w "%{http_code}" \
+              -H "Authorization: token $GITEA_TOKEN" \
+              "$GITEA_API/repos/$REPO/releases/tags/$TAG"
+          )
+
+          if [ "$release_id" = "200" ]; then
+            echo "Release for $TAG already exists; reusing it."
+            release_id=$(json_id < /tmp/rel.json)
+          else
+            echo "Creating release for $TAG."
+            release_id=$(
+              curl -s -o /tmp/rel.json -w "%{http_code}" -X POST \
+                -H "Authorization: token $GITEA_TOKEN" \
+                -H "Content-Type: application/json" \
+                -d "{\"tag_name\": \"$TAG\", \"name\": \"$TAG\", \"body\": \"Automated release build for $TAG\"}" \
+                "$GITEA_API/repos/$REPO/releases"
+            )
+            case "$release_id" in
+              201|200) release_id=$(json_id < /tmp/rel.json) ;;
+              *) echo "::error::release create returned HTTP $release_id: $(cat /tmp/rel.json)"; exit 1 ;;
+            esac
+          fi
+
+          echo "Uploading asset to release $release_id."
+          resp=$(curl -s -o /tmp/att.json -w "%{http_code}" -X POST \
+             -H "Authorization: token $GITEA_TOKEN" \
+             -F "attachment=@vidplex-${TAG}.zip" \
+             "$GITEA_API/repos/$REPO/releases/$release_id/assets")
+          if [ "$resp" != "200" ] && [ "$resp" != "201" ]; then
+            echo "::error::asset upload returned HTTP $resp: $(cat /tmp/att.json)"
+            exit 1
+          fi
+          cat /tmp/att.json
+          echo

__tests__/instructions_ui.test.mjs

@@ -130,16 +130,26 @@ function installPopupDom() {
   };
 }
 
-async function mountPopup() {
+async function mountPopupWithStorage(storageGet = async () => ({}), captureWrite = null) {
   const { dom, cleanup } = installPopupDom();
+  // Override the chrome.storage.local stub so we can seed a value and capture writes.
+  const writes = [];
+  globalThis.chrome.storage.local.get = async (...args) => {
+    const res = await storageGet(...args);
+    return res;
+  };
+  globalThis.chrome.storage.local.set = async (items) => {
+    if (captureWrite) captureWrite(items); else writes.push(items);
+  };
   const moduleUrl = new URL('../src/viewer/index.js?test=' + Date.now(), import.meta.url);
   await import(moduleUrl.href);
-  return { dom, cleanup };
+  const flush = () => new Promise((resolve) => setTimeout(resolve, 0));
+  return { dom, cleanup, writes, flush };
 }
 
 describe('Viewer popup instructions', () => {
   it('renders the drafted instructions copy on mount with accessible labeling', async () => {
-    const { dom, cleanup } = await mountPopup();
+    const { dom, cleanup } = await mountPopupWithStorage();
     try {
       const doc = dom.window.document;
       const region = doc.querySelector('.instructions-panel');
@@ -180,7 +190,7 @@ describe('Viewer popup instructions', () => {
   });
 
   it('toggles the instructions panel open and closed', async () => {
-    const { dom, cleanup } = await mountPopup();
+    const { dom, cleanup } = await mountPopupWithStorage();
     try {
       const doc = dom.window.document;
       const toggle = doc.getElementById('instructions-toggle');
@@ -201,4 +211,59 @@ describe('Viewer popup instructions', () => {
       cleanup();
      }
    });
+
+  it('honors a stored hidden state on mount', async () => {
+    const { dom, cleanup } = await mountPopupWithStorage(
+      async () => ({ goon_instructions_visible: false })
+     );
+    try {
+      const doc = dom.window.document;
+      const toggle = doc.getElementById('instructions-toggle');
+      const body = doc.getElementById('instructions-body');
+      // Wait for the async storage.get() to resolve and apply.
+      await new Promise((r) => setTimeout(r, 0));
+      if (toggle.getAttribute('aria-expanded') !== 'false') throw new Error('Stored hidden state should start collapsed');
+      if (!body.hidden) throw new Error('Stored hidden state should start hidden');
+      if (toggle.textContent !== 'Show instructions') throw new Error('Stored hidden state should show the "Show instructions" label');
+     } finally {
+      cleanup();
+     }
+   });
+
+  it('persists the new visibility on every user toggle', async () => {
+    let written = null;
+    const { dom, cleanup, flush } = await mountPopupWithStorage(
+      async () => ({}),
+      (items) => { written = items; }
+     );
+    try {
+      const doc = dom.window.document;
+      const toggle = doc.getElementById('instructions-toggle');
+      // Collapse -> must persist false.
+      toggle.click();
+      await flush();
+      if (written === null) throw new Error('Collapsing the panel must write to chrome.storage.local');
+      if (written.goon_instructions_visible !== false) throw new Error('Collapsing must persist goon_instructions_visible=false');
+      // Expand -> must persist true.
+      toggle.click();
+      await flush();
+      if (written.goon_instructions_visible !== true) throw new Error('Expanding must persist goon_instructions_visible=true');
+     } finally {
+      cleanup();
+     }
+   });
+
+  it('defaults a first-time user (no stored key) to shown', async () => {
+    const { dom, cleanup } = await mountPopupWithStorage(async () => ({}));
+    try {
+      const doc = dom.window.document;
+      const toggle = doc.getElementById('instructions-toggle');
+      const body = doc.getElementById('instructions-body');
+      await new Promise((r) => setTimeout(r, 0));
+      if (toggle.getAttribute('aria-expanded') !== 'true') throw new Error('First-time user should start expanded');
+      if (body.hidden) throw new Error('First-time instructions body should be visible on mount');
+     } finally {
+      cleanup();
+     }
+   });
 });

manifest.json

@@ -1,7 +1,7 @@
 {
   "manifest_version": 3,
   "name": "VidPlex",
-  "version": "0.1.0",
+   "version": "0.2.0",
   "description": "Find videos on any page and view them in a grid.",
       "permissions": [
           "storage",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "vidplex",
-  "version": "0.1.0",
+   "version": "0.2.0",
   "private": true,
   "description": "Chrome extension: find videos on a page and view them in a grid.",
   "type": "module",

src/viewer/index.js

@@ -6,6 +6,11 @@
 
 const STORAGE_KEY = 'goon_videos';
 const TAGGED_KEY = 'goon_tagged';
+// Durable "hide instructions" toggle. Absent key === SHOWN (true), matching the
+// first-time "expanded on mount" behavior. chrome.storage.local is extension-wide,
+// so the viewer window and every popup instance read/write the same value — the
+// preference is respected application-wide and survives reloads / SW termination.
+const INSTRUCTIONS_VISIBLE_KEY = 'goon_instructions_visible';
 
 // Set to true to enable verbose console output in the popup.
 const DEBUG = true;  // TEMP: enabled for debugging — revert to false when done
@@ -48,9 +53,22 @@ function setInstructionsExpanded(expanded) {
 }
 
 if (instructionsToggle && instructionsBody) {
+  // On mount, read the stored visibility. An absent key means SHOWN (true), so a
+  // first-time user still sees the steps. The viewer window reads the same
+  // extension-wide key, so the choice is respected across the whole app.
+  chrome.storage.local.get(INSTRUCTIONS_VISIBLE_KEY).then(stored => {
+    const visible = stored[INSTRUCTIONS_VISIBLE_KEY];
+    setInstructionsExpanded(visible === undefined ? true : visible);
+  }).catch(() => {
+    // Any read failure falls back to shown.
     setInstructionsExpanded(true);
+  });
+  // On every user toggle, apply in-DOM and persist. Both directions write, so
+  // the state survives reloads and SW termination until the user flips it again.
   instructionsToggle.addEventListener('click', () => {
-    setInstructionsExpanded(instructionsBody.hidden);
+    const next = instructionsBody.hidden;
+    setInstructionsExpanded(next);
+    chrome.storage.local.set({ [INSTRUCTIONS_VISIBLE_KEY]: next });
   });
 }