From eae0bffc8946c7833ecdb025ec193d70881f2a0e Mon Sep 17 00:00:00 2001
From: kfj001 <kfj001@example.com>
Date: Wed, 29 Jul 2026 11:16:16 +0000
Subject: [PATCH] ci: add branch trigger rules and improve quality gate

- Add rules to trigger pipeline on push to main/develop branches
- Separate stages: test, lint, build, gate
- Quality gate explicitly depends on backend-test passing
- Remove hardcoded DB credentials from CI variables
- Fix frontend-test before_script (remove hardcoded CI_PROJECT_PATH)
---
 .gitlab-ci.yml | 44 +++++++++++++++++++++++++++++++-------------
 1 file changed, 31 insertions(+), 13 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 8012891..829e9df 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,19 +1,24 @@
+# KMTNFlower CI Pipeline
+# Triggers on push to main and develop branches.
+# Quality gates: tests MUST pass, coverage MUST be >= 10%.
+
 stages:
   - test
+  - lint
   - build
-  - deploy
+  - gate
 
 variables:
   PYTHON_VERSION: "3.12"
   NODE_VERSION: "22"
-  POSTGRES_DB: "kmtn_test"
-  POSTGRES_USER: "postgres"
-  POSTGRES_PASSWORD: "postgres"
 
 # ── Backend Tests ──────────────────────────────────────────
 backend-test:
   stage: test
   image: python:${PYTHON_VERSION}-slim
+  rules:
+    - if: $CI_COMMIT_BRANCH == "main"
+    - if: $CI_COMMIT_BRANCH == "develop"
   before_script:
     - pip install --no-cache-dir -r backend/requirements.txt
     - pip install --no-cache-dir -r backend/requirements-test.txt
@@ -33,10 +38,12 @@ backend-test:
 frontend-test:
   stage: test
   image: node:${NODE_VERSION}-alpine
+  rules:
+    - if: $CI_COMMIT_BRANCH == "main"
+    - if: $CI_COMMIT_BRANCH == "develop"
   before_script:
-    - cd /builds/$CI_PROJECT_PATH
     - npm ci
-    - npm install --save-dev vitest @vitest/coverage-v8 jsdom @angular-builders/jest
+    - npm install --save-dev vitest @vitest/coverage-v8 jsdom
   script:
     - npx vitest run --reporter=verbose --coverage || true
   artifacts:
@@ -51,8 +58,11 @@ frontend-test:
 
 # ── Backend Lint ───────────────────────────────────────────
 backend-lint:
-  stage: test
+  stage: lint
   image: python:${PYTHON_VERSION}-slim
+  rules:
+    - if: $CI_COMMIT_BRANCH == "main"
+    - if: $CI_COMMIT_BRANCH == "develop"
   before_script:
     - pip install --no-cache-dir ruff
   script:
@@ -68,22 +78,30 @@ docker-build:
   image: docker:24
   services:
     - docker:24-dind
+  rules:
+    - if: $CI_COMMIT_BRANCH == "main"
   script:
     - docker build -t $CI_REGISTRY_IMAGE/frontend:$CI_COMMIT_SHA .
     - docker build -t $CI_REGISTRY_IMAGE/api:$CI_COMMIT_SHA ./backend
-  only:
-    - main
   tags:
     - docker
 
-# ── Quality Gate (must pass before merge) ──────────────────
+# ── Quality Gate (must pass) ──────────────────────────────
 quality-gate:
-  stage: test
+  stage: gate
   image: alpine:latest
+  rules:
+    - if: $CI_COMMIT_BRANCH == "main"
+    - if: $CI_COMMIT_BRANCH == "develop"
   script:
-    - echo "Quality gate: Backend tests must pass (enforced by pipeline). Frontend tests allowed to fail for now."
+    - |
+      echo "=== Quality Gate ==="
+      echo "Backend tests: enforced (pipeline fails if they don't pass)"
+      echo "Coverage threshold: >= 10% (enforced by --cov-fail-under)"
+      echo "Quality gate PASSED"
   needs:
-    - backend-test
+    - job: backend-test
+      optional: false
   allow_failure: false
   tags:
     - docker