fix(ci): address Kyle's review feedback
CI / Lint (pull_request) Failing after 2m44s
CI / Test (pull_request) Successful in 2m28s
CI / Build Android (pull_request) Canceled after 34s
CI / Build iOS (pull_request) Canceled after 0s

- Pin runner labels: ubuntu-latest -> ubuntu-24.04 (lint, test, build-android)
- Fix iOS runner: ubuntu-latest -> [self-hosted, macos]
- Install JDK via apt-get instead of manual curl download
- Update JAVA_HOME to /usr/lib/jvm/java-17-openjdk-amd64
This commit is contained in:
robot committed 2026-08-03 23:00:35 +00:00
1 parent 1f74477594
commit a1c0954a4d
1 file changed
+14 -16
+14 -16
View File
@@ -32,7 +32,7 @@ jobs:
# ── Stage 1: Lint & static analysis (best-effort on any runner) ── # ── Stage 1: Lint & static analysis (best-effort on any runner) ──
lint: lint:
name: Lint name: Lint
runs-on: ubuntu-latest runs-on: ubuntu-24.04
continue-on-error: true continue-on-error: true
steps: steps:
- name: Checkout - name: Checkout
@@ -71,7 +71,7 @@ jobs:
# ── Stage 1 (parallel): Unit & widget tests (best-effort) ─────── # ── Stage 1 (parallel): Unit & widget tests (best-effort) ───────
test: test:
name: Test name: Test
runs-on: ubuntu-latest runs-on: ubuntu-24.04
continue-on-error: true continue-on-error: true
steps: steps:
- name: Checkout - name: Checkout
@@ -104,7 +104,7 @@ jobs:
# ── Stage 3: Android build ────────────────────────────────────── # ── Stage 3: Android build ──────────────────────────────────────
build-android: build-android:
name: Build Android name: Build Android
runs-on: ubuntu-latest runs-on: ubuntu-24.04
needs: [lint, test] needs: [lint, test]
steps: steps:
- name: Checkout - name: Checkout
@@ -122,12 +122,10 @@ jobs:
- name: Setup Java 17 - name: Setup Java 17
run: | run: |
set -e set -e
curl -fsSL "https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.12%2B7/OpenJDK17U-jdk_x64_linux_hotspot_17.0.12_7.tar.gz" \ apt-get update
-o /tmp/jdk.tar.gz apt-get install -y openjdk-17-jdk
mkdir -p "$HOME/jdk" export JAVA_HOME="/usr/lib/jvm/java-17-openjdk-amd64"
tar -xzf /tmp/jdk.tar.gz -C "$HOME/jdk" --strip-components=1 export PATH="$JAVA_HOME/bin:$PATH"
export PATH="$HOME/jdk/bin:$PATH"
export JAVA_HOME="$HOME/jdk"
java -version java -version
- name: Setup Flutter - name: Setup Flutter
@@ -142,8 +140,8 @@ jobs:
- name: Install Android SDK command-line tools - name: Install Android SDK command-line tools
run: | run: |
set -e set -e
export JAVA_HOME="$HOME/jdk" export JAVA_HOME="/usr/lib/jvm/java-17-openjdk-amd64"
export PATH="$HOME/jdk/bin:$PATH" export PATH="/usr/lib/jvm/java-17-openjdk-amd64/bin:$PATH"
export ANDROID_HOME="${HOME}/android-sdk" export ANDROID_HOME="${HOME}/android-sdk"
mkdir -p "${ANDROID_HOME}/cmdline-tools" mkdir -p "${ANDROID_HOME}/cmdline-tools"
curl -fsSL "https://dl.google.com/android/repository/commandlinetools-linux-11076708_latest.zip" -o /tmp/cmdline-tools.zip curl -fsSL "https://dl.google.com/android/repository/commandlinetools-linux-11076708_latest.zip" -o /tmp/cmdline-tools.zip
@@ -160,8 +158,8 @@ jobs:
- name: Accept Android SDK licenses - name: Accept Android SDK licenses
run: | run: |
export JAVA_HOME="$HOME/jdk" export JAVA_HOME="/usr/lib/jvm/java-17-openjdk-amd64"
export PATH="$HOME/jdk/bin:$PATH" export PATH="/usr/lib/jvm/java-17-openjdk-amd64/bin:$PATH"
yes | "${HOME}/android-sdk/cmdline-tools/latest/bin/sdkmanager" --licenses || true yes | "${HOME}/android-sdk/cmdline-tools/latest/bin/sdkmanager" --licenses || true
- name: Install dependencies - name: Install dependencies
@@ -182,14 +180,14 @@ jobs:
- name: Build APK (release) - name: Build APK (release)
run: | run: |
export JAVA_HOME="$HOME/jdk" export JAVA_HOME="/usr/lib/jvm/java-17-openjdk-amd64"
export ANDROID_HOME="${HOME}/android-sdk" export ANDROID_HOME="${HOME}/android-sdk"
export PATH="$PWD/flutter/bin:$PATH" export PATH="$PWD/flutter/bin:$PATH"
flutter build apk --release flutter build apk --release
- name: Build App Bundle (release) - name: Build App Bundle (release)
run: | run: |
export JAVA_HOME="$HOME/jdk" export JAVA_HOME="/usr/lib/jvm/java-17-openjdk-amd64"
export ANDROID_HOME="${HOME}/android-sdk" export ANDROID_HOME="${HOME}/android-sdk"
export PATH="$PWD/flutter/bin:$PATH" export PATH="$PWD/flutter/bin:$PATH"
flutter build appbundle --release flutter build appbundle --release
@@ -212,7 +210,7 @@ jobs:
# ── Stage 2 (parallel): iOS build ─────────────────────────────── # ── Stage 2 (parallel): iOS build ───────────────────────────────
build-ios: build-ios:
name: Build iOS name: Build iOS
runs-on: ubuntu-latest runs-on: [self-hosted, macos]
needs: [lint, test] needs: [lint, test]
if: always() if: always()
steps: steps: