WesternTechnologies/goon_plugin
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

refactor: decouple from site-specific CDN references #5

Merged
kfj001 merged 11 commits from feature/no_mention_of_pornhub into master 2026-08-30 17:07:52 -07:00
Conversation 6 Commits 11 Files Changed 16
+9 -1
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 62d1244558 - Show all commits
.claude/settings.local.json
+9 -1
View File
@@ -3,7 +3,15 @@
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"allow": [
"Bash(npm run *)",
"Bash(node --check /home/kyle/Documents/goon_plugin/src/viewer/index.js)",
"Bash(open -a \"Microsoft Edge\" --args --remote-debugging-port=9222 --profile-directory=Default)"
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(open -a \"Microsoft Edge\" --args --remote-debugging-port=9222 --profile-directory=Default)",
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(git checkout *)",
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(node --check src/viewer/index.js)",
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)",
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(node __tests__/run.mjs)",
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(node -e \"console.log\\(\\(require\\('./package.json'\\).scripts||{}\\).build || '\\(no build script\\)'\\)\")",
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(git check-ignore *)",
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(node --check __tests__/simple_video.test.mjs)",
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
"Bash(node --check __tests__/run.mjs)"
robot commented 2026-08-30 01:14:31 -07:00
Review
Copy link
Copy source

[SHOULD-FIX] F3
A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored.
Suggested fix: Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.

[SHOULD-FIX] F3 A tool-local settings file is committed to the shared repo and now carries absolute local paths to the author's machine: 'Bash(node /Users/kyle/.claude/jobs/1462df8d/tmp/transform2.mjs)' and 'Bash(open -a "Microsoft Edge" ...)'. These are machine-specific and should not live in the shared codebase; .claude/settings.local.json is typically user-scoped and gitignored. **Suggested fix:** Drop .claude/settings.local.json from the PR (it is unrelated to the refactor) and/or add it to .gitignore so per-machine tool settings never get committed.
]
}
}