WesternTechnologies/goon_plugin
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Feature/rebrand #4

Merged
kfj001 merged 4 commits from feature/rebrand into master 2026-08-24 18:42:43 -07:00
Conversation 5 Commits 4 Files Changed 9
+1 -2
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7d56e836c9 - Show all commits
vidplex.code-workspace
+1 -2
View File
@@ -6,7 +6,6 @@
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

Blocking: typescript.tsdk is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib). js/ts.tsdk.path is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to "typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.

**Blocking:** `typescript.tsdk` is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (`node_modules/typescript/lib`). `js/ts.tsdk.path` is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to `"typescript.tsdk": "node_modules/typescript/lib"`. This change is also out of scope for a pure rebrand.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.

`fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

Blocking: typescript.tsdk is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib). js/ts.tsdk.path is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to "typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.

**Blocking:** `typescript.tsdk` is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (`node_modules/typescript/lib`). `js/ts.tsdk.path` is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to `"typescript.tsdk": "node_modules/typescript/lib"`. This change is also out of scope for a pure rebrand.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.

`fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
], ],
"extensions": { "extensions": {
"recommendations": [ "recommendations": [
"fmvilas.popup-previewer.ChromeExtensionPopupPreviewer",
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

Blocking: typescript.tsdk is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib). js/ts.tsdk.path is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to "typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.

**Blocking:** `typescript.tsdk` is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (`node_modules/typescript/lib`). `js/ts.tsdk.path` is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to `"typescript.tsdk": "node_modules/typescript/lib"`. This change is also out of scope for a pure rebrand.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.

`fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
"maslansnik.chromium-ext-debugger", "maslansnik.chromium-ext-debugger",
"dbaeumer.vscode-eslint", "dbaeumer.vscode-eslint",
"esbenp.prettier-vscode", "esbenp.prettier-vscode",
@@ -18,6 +17,6 @@
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

Blocking: typescript.tsdk is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib). js/ts.tsdk.path is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to "typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.

**Blocking:** `typescript.tsdk` is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (`node_modules/typescript/lib`). `js/ts.tsdk.path` is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to `"typescript.tsdk": "node_modules/typescript/lib"`. This change is also out of scope for a pure rebrand.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.

`fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

Blocking: typescript.tsdk is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib). js/ts.tsdk.path is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to "typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.

**Blocking:** `typescript.tsdk` is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (`node_modules/typescript/lib`). `js/ts.tsdk.path` is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to `"typescript.tsdk": "node_modules/typescript/lib"`. This change is also out of scope for a pure rebrand.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.

`fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
"editor.formatOnSave": true, "editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode", "editor.defaultFormatter": "esbenp.prettier-vscode",
"eslint.validate": ["javascript", "typescript"], "eslint.validate": ["javascript", "typescript"],
"typescript.tsdk": "node_modules/typescript/lib", "js/ts.tsdk.path": "node_modules/typescript/lib",
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

Blocking: typescript.tsdk is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib). js/ts.tsdk.path is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to "typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.

**Blocking:** `typescript.tsdk` is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (`node_modules/typescript/lib`). `js/ts.tsdk.path` is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to `"typescript.tsdk": "node_modules/typescript/lib"`. This change is also out of scope for a pure rebrand.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.

`fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

Blocking: typescript.tsdk is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib). js/ts.tsdk.path is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to "typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.

**Blocking:** `typescript.tsdk` is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (`node_modules/typescript/lib`). `js/ts.tsdk.path` is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to `"typescript.tsdk": "node_modules/typescript/lib"`. This change is also out of scope for a pure rebrand.
robot commented 2026-08-24 16:56:40 -07:00
Review
Copy link
Copy source

fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.

`fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
}, },
} }