Reviewed the full diff (9 files, +14/-15): a clean rebrand of goon_plugin -> VidPlex across user-facing surfaces.
Good
All 9 files valid and consistent: manifest.json (name+description), index.html / viewer.html titles, package.json / package-lock.json name, icon.svg letter (G->V), README, devcontainer, and the workspace-file rename are all updated correctly.
Zero regressions: test runner 82/83 on BOTH feature/rebrand and master (the single "dist/hlds.js not found" failure is pre-existing on master, not introduced here). No new tsc errors (vite.config.ts is untouched by this PR; its 13 pre-existing errors remain). All JSON validates.
Blocking
vidplex.code-workspace:20 -- typescript.tsdk was changed to js/ts.tsdk.path, which is NOT a recognized VS Code setting. It looks like a typo that silently disables the TypeScript language-service SDK path. Also out of scope for a pure rebrand. Suggest reverting the line to "typescript.tsdk": "node_modules/typescript/lib".
Scope
vidplex.code-workspace -- fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed with no rationale. Unrelated to a rebrand; restore it or move the removal to its own PR.
FYI (not blocking)
Residual goon identifiers remain (message constants like GOON_GET_VIDEO_DATA / GOON_PROXY_FETCH, storage keys goon_videos / goon_tagged, _goon_plugin* window globals, [goon-*] log prefixes, .goon-error-overlay CSS). These are cross-script contracts and backward-compat storage keys, so leaving them is defensible -- just confirm it was intentional.
## Code Review -- CHANGES REQUESTED
Reviewed the full diff (9 files, +14/-15): a clean *rebrand* of goon_plugin -> VidPlex across user-facing surfaces.
### Good
- All 9 files valid and consistent: manifest.json (name+description), index.html / viewer.html titles, package.json / package-lock.json name, icon.svg letter (G->V), README, devcontainer, and the workspace-file rename are all updated correctly.
- **Zero regressions**: test runner 82/83 on BOTH feature/rebrand and master (the single "dist/hlds.js not found" failure is pre-existing on master, not introduced here). No new tsc errors (vite.config.ts is untouched by this PR; its 13 pre-existing errors remain). All JSON validates.
### Blocking
- **vidplex.code-workspace:20** -- `typescript.tsdk` was changed to **`js/ts.tsdk.path`**, which is NOT a recognized VS Code setting. It looks like a typo that silently disables the TypeScript language-service SDK path. Also out of scope for a pure rebrand. Suggest reverting the line to `"typescript.tsdk": "node_modules/typescript/lib"`.
### Scope
- **vidplex.code-workspace** -- `fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed with no rationale. Unrelated to a rebrand; restore it or move the removal to its own PR.
### FYI (not blocking)
Residual `goon` identifiers remain (message constants like GOON_GET_VIDEO_DATA / GOON_PROXY_FETCH, storage keys goon_videos / goon_tagged, __goon_plugin_* window globals, [goon-*] log prefixes, .goon-error-overlay CSS). These are cross-script contracts and backward-compat storage keys, so leaving them is defensible -- just confirm it was intentional.
Blocking:typescript.tsdk is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib). js/ts.tsdk.path is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to "typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.
**Blocking:** `typescript.tsdk` is a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (`node_modules/typescript/lib`). `js/ts.tsdk.path` is NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to `"typescript.tsdk": "node_modules/typescript/lib"`. This change is also out of scope for a pure rebrand.
fmvilas.popup-previewer.ChromeExtensionPopupPreviewer (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
`fmvilas.popup-previewer.ChromeExtensionPopupPreviewer` (a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.
Reviewed the full diff at current head cb607306 (9 files, +13/-13): a clean goon_plugin -> VidPlex rebrand across user-facing surfaces. Both items from the earlier (stale) REQUEST_CHANGES on 7d56e836 are fixed by the latest commit "Reverts plugin changes unrelated to rebranding efforts": typescript.tsdk back to node_modules/typescript/lib, and fmvilas.popup-previewer restored to suggestions. vidplex.code-workspace at head is byte-identical to goon_plugin.code-workspace on master (rename only). No source-logic changes. mergeable: true. LGTM.
## APPROVED
Reviewed the full diff at current head cb607306 (9 files, +13/-13): a clean goon_plugin -> VidPlex rebrand across user-facing surfaces. Both items from the earlier (stale) REQUEST_CHANGES on 7d56e836 are fixed by the latest commit "Reverts plugin changes unrelated to rebranding efforts": typescript.tsdk back to node_modules/typescript/lib, and fmvilas.popup-previewer restored to suggestions. vidplex.code-workspace at head is byte-identical to goon_plugin.code-workspace on master (rename only). No source-logic changes. mergeable: true. LGTM.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
robot
Code Review -- CHANGES REQUESTED
Reviewed the full diff (9 files, +14/-15): a clean rebrand of goon_plugin -> VidPlex across user-facing surfaces.
Good
Blocking
typescript.tsdkwas changed tojs/ts.tsdk.path, which is NOT a recognized VS Code setting. It looks like a typo that silently disables the TypeScript language-service SDK path. Also out of scope for a pure rebrand. Suggest reverting the line to"typescript.tsdk": "node_modules/typescript/lib".Scope
fmvilas.popup-previewer.ChromeExtensionPopupPreviewer(a useful Chrome-extension popup previewer) was removed with no rationale. Unrelated to a rebrand; restore it or move the removal to its own PR.FYI (not blocking)
Residual
goonidentifiers remain (message constants like GOON_GET_VIDEO_DATA / GOON_PROXY_FETCH, storage keys goon_videos / goon_tagged, _goon_plugin* window globals, [goon-*] log prefixes, .goon-error-overlay CSS). These are cross-script contracts and backward-compat storage keys, so leaving them is defensible -- just confirm it was intentional.Blocking:
typescript.tsdkis a real, documented VS Code setting that points the TypeScript language service at a bundled tsserver (node_modules/typescript/lib).js/ts.tsdk.pathis NOT a recognized VS Code setting -- this looks like a typo that will silently disable the SDK path. Suggest reverting this line to"typescript.tsdk": "node_modules/typescript/lib". This change is also out of scope for a pure rebrand.fmvilas.popup-previewer.ChromeExtensionPopupPreviewer(a useful Chrome-extension popup previewer) was removed here with no rationale. It is unrelated to the rebrand -- please restore it, or move the removal to its own PR.APPROVED
Reviewed the full diff at current head
cb607306(9 files, +13/-13): a clean goon_plugin -> VidPlex rebrand across user-facing surfaces. Both items from the earlier (stale) REQUEST_CHANGES on7d56e836are fixed by the latest commit "Reverts plugin changes unrelated to rebranding efforts": typescript.tsdk back to node_modules/typescript/lib, and fmvilas.popup-previewer restored to suggestions. vidplex.code-workspace at head is byte-identical to goon_plugin.code-workspace on master (rename only). No source-logic changes. mergeable: true. LGTM.LGTM - clean rebrand, both prior blockers fixed. Official approval.
LGTM
Clean rebrand, both prior blockers fixed, no logic changes. Official approval.